-
-
Notifications
You must be signed in to change notification settings - Fork 811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimisation for backend by caching requests for users. #3842
Conversation
Can we have 2.2 version too... this is awesome. |
@rossriley Surely. I'll backport this to 2.2.x after it has landed. |
Just a few issues I am looking at 😁 |
@bobdenotter acceptance tests were broken due to the permissions changes. I have modified the flow a bit and it passes locally… So back over to you for approval I guess. Note: With your original changes, we already know if we have a |
Hooray for teamwork! 🎉 |
ac913f9
to
f83b1cf
Compare
Booom! |
Optimisation for backend by caching requests for users.
As pointed out by @rossriley: No need to fetch users every single time. This PR fetches them once, and returns from memory if possible. This yields a significant improvement in queries / time taken.
Before:
After: