Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing default and base-2014 themes. Only base-2016 should stay. #5093

Merged
merged 5 commits into from
Mar 30, 2016

Conversation

bobdenotter
Copy link
Member

No description provided.

@GwendolenLynch
Copy link
Contributor

I love the branch name 😸

@bobdenotter
Copy link
Member Author

There should be only one test failure left:

There was 1 failure:

1) Bolt\Tests\Twig\TextHandlerTest::testLocaleDateTimeCdo
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-2012-06-14 09:07:55
+June 14, 2012 09:07

/Users/bob/Sites/bolt-testing/tests/phpunit/unit/Twig/Handler/TextHandlerTest.php:72

Relevant code:

        $result = $handler->localeDateTime('2012-06-14 09:07:55', '%B %e, %Y %H:%M');
        $this->assertSame('2012-06-14 09:07:55', $result);

Why did that work?

@GwendolenLynch
Copy link
Contributor

It passes here… have you set a locale format somewhere else?

@GwendolenLynch
Copy link
Contributor

Oh… nvm, Travis failing too

@bobdenotter
Copy link
Member Author

Weird stuff, right? :-)

@bobdenotter
Copy link
Member Author

Looking at the output:

--- Expected
+++ Actual
@@ @@
-2012-06-14 09:07:55
+June 14, 2012 09:07

What is printed for actual does actually make sense, right? How would / should that code produce 2012-06-14 09:07:55 ?

@GwendolenLynch
Copy link
Contributor

Yeah, but it is mocked earlier up and setlocale() should return a false.

@GwendolenLynch GwendolenLynch merged commit eb4dc70 into master Mar 30, 2016
@GwendolenLynch GwendolenLynch deleted the killing-your-darlings branch March 30, 2016 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants