Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating default debug_error_level from 6135 to 8181. #5751

Merged
merged 1 commit into from
Sep 12, 2016

Conversation

bobdenotter
Copy link
Member

@bobdenotter bobdenotter commented Sep 12, 2016

No description provided.

@GwendolenLynch
Copy link
Contributor

Well, on 3.2 if you have it turned up that high, Symfony converts errors to exceptions … so do this with caution 😄

@bobdenotter
Copy link
Member Author

bobdenotter commented Sep 12, 2016

@GawainLynch it's 8181 in config.yml.dist as well, so it makes sense that they're consistent, at least. https://github.com/bolt/bolt/blob/release/3.1/app/config/config.yml.dist#L261

@GwendolenLynch
Copy link
Contributor

Yeah, but we still might want to tone down the default, and advise people tracing issues to turn it up.

@bobdenotter
Copy link
Member Author

Actually, this is "toning it down" compared to the previous version, right?

previous: "all, but not notices and deprecations"
new: "all, but not notices, deprecations and also not warnings"

@GwendolenLynch
Copy link
Contributor

Possibly… But I've been having to wind my setting down at certain times lately on release/3.2+.

@bobdenotter
Copy link
Member Author

I'm not at all against reviewing the setting for 3.2, but I think this PR does make it more consistent for 3.1.. And when we update for 3.2, it'll be easier to find the two same values to update them to whatever we choose to set it to. ;-)

@GwendolenLynch
Copy link
Contributor

There you go with the logic again… 😜

@GwendolenLynch GwendolenLynch merged commit cf16a29 into release/3.1 Sep 12, 2016
@GwendolenLynch GwendolenLynch deleted the fix/default-debug_error_level branch September 12, 2016 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants