Check file_uploads ini directive for allowed uploads

[ozdemirburak]

Hoping that it fixes the issue #5963.

There may be one possible issue with testing where the user is not allowed to change the file_uploads ini directive.

That's why added the code block below to the tests.

if (ini_set('file_uploads', '0') !== false) {
    ...
}

[GwendolenLynch]

@CarsonF can you 👍 / 👎 … I know we're aiming to nuke the permission class, but short term this looks to get us something

[bobdenotter]

Bumping @CarsonF 👊

[GwendolenLynch]

@bobdenotter just flagging, if you're near the green button, I want to send this to a lower version branch than master

[CarsonF]

I would rather use an Exception class/subclass from Bolt\Filesystem or Symfony\Filesystem. This class is kind of an odd ball right now. It will probably be removed within a few versions.

I also don't love an exception being thrown from a "check" method that returns a boolean. I would expect it just to return false. But that leaves us with no information...

[ozdemirburak]

@CarsonF updated, couldn't find any specific exception but IOException.

[CarsonF]

@GawainLynch What do you think? I'm thinking a subclass should be created for this. It doesn't really feel like an IO exception. Although the subclass could extend IO.

[GwendolenLynch]

I'm thinking a subclass should be created for this. It doesn't really feel like an IO exception. Although the subclass could extend IO.

Well right this second it is something of a moot point, as we're not catching the exception, and providing feedback. This is into the editor zone of UX after all.

But yeah, a ThisIsNotTheIniSettingYouAreLookingForException() might be a bit more useful in catching and displaying something in a clean way. The question becomes, what?

[GwendolenLynch]

Merged into release/3.3 via 83fa3db

Thanks for your patience @ozdemirburak 👍