Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only render Live editor save button when content type is set #6182

Merged
merged 2 commits into from Dec 19, 2016
Merged

Only render Live editor save button when content type is set #6182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca1a09f
Only render Live editor save button when content type is set
robertrosman Dec 17, 2016
7aa0962
Making the tests pass
robertrosman Dec 19, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions app/view/twig/_nav/_primary.twig
View file
Open in desktop
Expand Up @@ -29,12 +29,14 @@
</a>
</li>

{% if context.contenttype is defined %}
<li id="liveeditorsavecontinuebutton" class="save-live-editor">
<a>
<i class="fa fa-fw fa-flag"></i>
{{ __('contenttypes.generic.save', {'%contenttype%': context.contenttype.slug}) }}
</a>
</li>
{% endif %}

<li class="close-live-editor">
<a>
Expand Down
4 changes: 2 additions & 2 deletions tests/codeception/acceptance/101-BackendEditor/BackendEditorCest.php
View file
Open in desktop
Expand Up @@ -82,7 +82,7 @@ public function createRecordsTest(\AcceptanceTester $I)
$I->fillField('#teaser', 'Woop woop woop! Crazy nice stuff inside!');
$I->fillField('#body', 'Take it, take it! I have three more of these!');

$I->click('Save Page');
$I->click('Save Page', "#savecontinuebutton");
$I->see('The new Page has been saved.');

$I->see('A page I made');
Expand Down Expand Up @@ -232,7 +232,7 @@ public function checkTemplateFieldsTest(\AcceptanceTester $I)
$I->see('Template', 'a[data-toggle=tab]');

$I->fillField('#templatefields-section_1', 'This is the contact text');
$I->click('Save Page');
$I->click('Save Page', "#savecontinuebutton");

$I->click('CONTACT PAGE');
/*
Expand Down