Add support for extension definition in bolt.yml file #6324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
GwendolenLynch
suggested changes
Jan 31, 2017
app/bootstrap.php
Outdated
| $extensionClass = new $extensionClass(); | ||
| } | ||
| if ($extensionClass instanceof ExtensionInterface) { | ||
| $extensionArray[] = $extensionClass; |
There was a problem hiding this comment.
Can we invert and throw an exception as discussed in Slack?
|
Would it be better to do that logic inside of the extend closure? Wouldn't have to have a temp array. Maybe there would be some other benefit from doing it lazily? |
GwendolenLynch
approved these changes
Jan 31, 2017
CarsonF
approved these changes
Jan 31, 2017
|
Sweet! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows locally autoloadable extensions to be added via the bolt.yml file.