[Tests] Back-port of deprecations work #6356
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a back port of the unit test updates in #6083 … with the one addition being a helper function in
BoltUnitTest
that exists in PHPUnit 5.0+ and will get dropped from master on branch merge.Basically
$this->getMock()
is deprecated in PHPUnit 5.0 and makes a lot of noise at test time, hence part of #6083. As we need to take a bit of a look at our testing, it make sense to use forward compatible tests from the start.