Decouple exceptions from exception handling #6361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @param Exception|null $previous | ||
| * @param int $code | ||
| */ | ||
| public function __construct($driver, $message = "", Exception $previous = null, $code = 0) |
There was a problem hiding this comment.
My OCD would like to know if that is copy/pasta? :wink
GwendolenLynch
force-pushed
the
refactor-exceptions
branch
from
6565fe0
to
3bcf272
Compare
GwendolenLynch
changed the title
… -4 (up from -8).
… upped the priority to -7
…esn't subscribe it if its disabled.
GwendolenLynch
force-pushed
the
refactor-exceptions
branch
from
3bcf272
to
7c7a57c
Compare
GwendolenLynch
approved these changes
Feb 7, 2017
|
CC builds are having issues with our ruleset … ignoring. Thanks for picking up the last of this chunk of work @CarsonF |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably a couple things left to finish, but here's the idea.