[3.3] Core deprecation notice logging

src/Asset/Target.php

@@ -79,6 +79,7 @@ class Target
      */
     public function listAll()
     {
+        @trigger_error(sprintf('%s is deprecated and will be removed in version 4.0.', __METHOD__), E_USER_DEPRECATED);
         $reflection = new \ReflectionClass($this);
 
         return $reflection->getConstants();

src/Cache.php

@@ -45,6 +45,8 @@ public function __construct($directory, $extension = self::EXTENSION, $umask = 0
      */
     public function clearCache()
     {
+        @trigger_error(sprintf('%s is deprecated and will be removed in version 4.0. Use flushAll() instead.', __METHOD__));
+
         $this->flushAll();
 
         return [

src/Configuration/ResourceManager.php

@@ -163,6 +163,8 @@ public function useLoader(ClassLoader $loader)
      */
     public function setApp(Application $app)
     {
+        @trigger_error(sprintf('%s is deprecated and will be removed in version 4.0.', __METHOD__), E_USER_DEPRECATED);
+
         $this->app = $app;
         self::$theApp = $app;
         $this->pathResolver = $app['path_resolver'];
@@ -179,6 +181,8 @@ public function setApp(Application $app)
      */
     public function setPath($name, $value, $applyToResolver = true)
     {
+        @trigger_error(sprintf('%s is deprecated and will be removed in version 4.0. Use \$app[\'path_resolver\'] instead.', __METHOD__), E_USER_DEPRECATED);
+
         if (strpos($value, '%') !== false) { // contains variable
             $path = function () use ($value) {
                 if (!$this->pathResolver) {
@@ -232,6 +236,8 @@ public function setPath($name, $value, $applyToResolver = true)
      */
     public function getPath($name)
     {
+        @trigger_error(sprintf('%s is deprecated and will be removed in version 4.0. Use \$app[\'path_resolver\'] instead.', __METHOD__), E_USER_DEPRECATED);
+
         return $this->getPathObject($name)->string();
     }
 
@@ -292,6 +298,7 @@ public function getPathObject($name)
      */
     public function hasPath($name)
     {
+        @trigger_error(sprintf('%s is deprecated and will be removed in version 4.0. Use \$app[\'path_resolver\'] instead.', __METHOD__), E_USER_DEPRECATED);
         if (strpos($name, '/') !== false) {
             $parts = explode('/', $name);
             $name = array_shift($parts);
@@ -406,6 +413,7 @@ public function getRequest($name)
      */
     public function getPaths()
     {
+        @trigger_error(sprintf('%s is deprecated and will be removed in version 4.0. Use \$app[\'path_resolver\'] instead.', __METHOD__), E_USER_DEPRECATED);
         if ($this->pathsProxy === null) {
             $this->pathsProxy = new PathsProxy($this);
         }
@@ -581,6 +589,7 @@ public function getClassLoader()
      */
     public static function getApp()
     {
+        @trigger_error(sprintf('%s is deprecated and will be removed in version 4.0.', __METHOD__), E_USER_DEPRECATED);
         if (! static::$theApp) {
             $trace = debug_backtrace(false);
             $trace = $trace[0]['file'] . '::' . $trace[0]['line'];
@@ -601,6 +610,8 @@ public static function getApp()
      */
     public function findRelativePath($frompath, $topath)
     {
+        @trigger_error(sprintf('%s is deprecated and will be removed in version 4.0. Use \$app[\'path_resolver\'] instead.', __METHOD__), E_USER_DEPRECATED);
+
         $filesystem = new Filesystem();
         $relative = $filesystem->makePathRelative($topath, $frompath);
 

src/Controller/Routing.php

@@ -11,6 +11,8 @@ class Routing extends Requirement
      */
     public function getAnyContentTypeRequirement()
     {
+        $this->deprecationNotice(__FUNCTION__, 'anyContentType');
+
         return $this->anyContentType();
     }
 
@@ -19,6 +21,8 @@ public function getAnyContentTypeRequirement()
      */
     public function getPluralContentTypeRequirement()
     {
+        $this->deprecationNotice(__FUNCTION__, 'pluralContentTypes');
+
         return $this->pluralContentTypes();
     }
 
@@ -27,6 +31,8 @@ public function getPluralContentTypeRequirement()
      */
     public function getAnyTaxonomyTypeRequirement()
     {
+        $this->deprecationNotice(__FUNCTION__, 'anyTaxonomyType');
+
         return $this->anyTaxonomyType();
     }
 
@@ -35,6 +41,8 @@ public function getAnyTaxonomyTypeRequirement()
      */
     public function getPluralTaxonomyTypeRequirement()
     {
+        $this->deprecationNotice(__FUNCTION__, 'pluralTaxonomyTypes');
+
         return $this->pluralTaxonomyTypes();
     }
 
@@ -48,6 +56,26 @@ public function getPluralTaxonomyTypeRequirement()
      */
     public function getTaxonomyRequirement($taxonomyName, $emptyValue = 'none')
     {
+        $this->deprecationNotice(__FUNCTION__, 'singleTaxonomy');
+
         return $this->singleTaxonomy($taxonomyName, $emptyValue);
     }
+
+    /**
+     * @param string $old Old function name
+     * @param string $new New function name
+     *
+     * @internal
+     */
+    private function deprecationNotice($old, $new)
+    {
+        @trigger_error(
+            sprintf(
+                'The app/config/routing.yml routing requirement parameter "Bolt\Controllers\Routing::%s" is deprecated and will be removed in version 4.0. Use "controller.requirement:%s" instead',
+                $old,
+                $new
+            ),
+            E_USER_DEPRECATED
+        );
+    }
 }

src/Extension/AssetTrait.php

@@ -137,6 +137,8 @@ private function addAsset(AssetInterface $asset)
      */
     protected function addJquery()
     {
+        @trigger_error(sprintf('%s::%s is deprecated and will be removed in version 4.0.', get_called_class(), __FUNCTION__), E_USER_DEPRECATED);
+
         $this->getContainer()['config']->set('general/add_jquery', true);
     }
 
@@ -147,6 +149,8 @@ protected function addJquery()
      */
     protected function disableJquery()
     {
+        @trigger_error(sprintf('%s::%s is deprecated and will be removed in version 4.0.', get_called_class(), __FUNCTION__), E_USER_DEPRECATED);
+
         $this->getContainer()['config']->set('general/add_jquery', false);
     }
 

src/Extension/Manager.php

@@ -326,6 +326,8 @@ private function isClassLoadable($className)
      */
     protected function getApp()
     {
+        @trigger_error(sprintf('%s is deprecated and will be removed in version 4.0. Inject the required services directly into your own service constructor as required.', __METHOD__), E_USER_DEPRECATED);
+
         return $this->app;
     }
 }

src/Extension/MenuTrait.php

@@ -75,6 +75,8 @@ function (MenuEntry $menus) {
      */
     final protected function addMenuEntry($label, $path, $icon = null, $permission = null)
     {
+        @trigger_error(sprintf('%s::%s is deprecated and will be removed in version 4.0. Use registerMenuEntries() instead.', get_called_class(), __FUNCTION__), E_USER_DEPRECATED);
+
         $this->menuEntries[] = (new MenuEntry($label, $path))
             ->setLabel($label)
             ->setIcon($icon)

src/Extension/NutTrait.php

@@ -44,6 +44,8 @@ final protected function extendNutService()
      */
     protected function addConsoleCommand(Command $command)
     {
+        @trigger_error(sprintf('%s::%s is deprecated and will be removed in version 4.0. Use registerNutCommands() instead.', get_called_class(), __FUNCTION__), E_USER_DEPRECATED);
+
         $app = $this->getContainer();
         $app['nut.commands.add']($command);
     }

src/Helpers/Arr.php

@@ -143,6 +143,7 @@ public static function column(array $input, $columnKey, $indexKey = null)
      */
     public static function makeValuePairs($array, $key, $value)
     {
+        @trigger_error(sprintf('%s is deprecated and will be removed in version 4.0. Use array_column() or Arr::column()', __METHOD__), E_USER_DEPRECATED);
         if (!is_array($array)) {
             return [];
         }
@@ -163,6 +164,7 @@ public static function makeValuePairs($array, $key, $value)
      */
     public static function mergeRecursiveDistinct(array &$array1, array &$array2)
     {
+        @trigger_error(sprintf('%s is deprecated and will be removed in version 4.0. Use array_replace_recursive() or Arr::replaceRecursive()', __METHOD__), E_USER_DEPRECATED);
         $merged = $array1;
 
         foreach ($array2 as $key => &$value) {
@@ -196,6 +198,8 @@ public static function mergeRecursiveDistinct(array &$array1, array &$array2)
      */
     public static function isIndexedArray(array $arr)
     {
+        @trigger_error(sprintf('%s is deprecated and will be removed in version 4.0. Use Arr::isIndexed() or Arr::isAssociative()', __METHOD__), E_USER_DEPRECATED);
+
         foreach ($arr as $key => $val) {
             if ($key !== (int) $key) {
                 return false;

src/Legacy/BaseExtension.php

@@ -25,6 +25,8 @@ abstract class BaseExtension extends SimpleExtension
      */
     public function __construct(Application $app)
     {
+        @trigger_error(sprintf('%s is extending the deprecated %s class that will be removed in version 4.0. Use \Bolt\Extension\SimpleExtension instead.', get_called_class(), __CLASS__), E_USER_DEPRECATED);
+
         $this->app = $app;
 
         $this->extensionConfig = null;

src/Menu/MenuBuilder.php

@@ -110,10 +110,8 @@ private function resolveRouteToLink(array $item)
         $param = !empty($item['param']) ? $item['param'] : [];
 
         if (isset($item['add'])) {
-            $this->app['logger.system']->warning(
-                Trans::__('Menu item property "add" is deprecated. Use "#" under "param" instead.'),
-                ['event' => 'deprecated']
-            );
+            @trigger_error('Menu item property "add" is deprecated. Use "#" under "param" instead.', E_USER_DEPRECATED);
+
             $add = $item['add'];
             if (!empty($add) && $add[0] !== '?') {
                 $add = '?' . $add;

src/Provider/DatabaseSchemaServiceProvider.php

@@ -63,7 +63,7 @@ function ($app) {
         /** @deprecated Deprecated since 3.0, to be removed in 4.0. */
         $app['integritychecker'] = $app->share(
             function ($app) {
-                $app['logger.system']->warning("[DEPRECATED]: An extension is using app['integritychecker'] and this has been replaced with app['schema'].", ['event' => 'deprecated']);
+                @trigger_error("Accessing \$app['integritychecker'] is deprecated and will be removed in version 4.0. Use \$app['schema'] instead.", E_USER_DEPRECATED);
 
                 return $app['schema'];
             }

src/Session/Generator/RandomGenerator.php

@@ -35,6 +35,8 @@ public function __construct($generator, $length = 32)
      */
     public function generateId()
     {
+        @trigger_error(sprintf('%s is deprecated and will be removed in version 4.0.', __CLASS__), E_USER_DEPRECATED);
+
         return $this->generator->generateString($this->length);
     }
 }

src/Storage/Database/Schema/Builder/ExtensionTables.php

@@ -75,6 +75,8 @@ public function getSchemaTables(Schema $schema)
      */
     public function addTable(callable $generator)
     {
+        @trigger_error(sprintf('%s is deprecated and will be removed in version 4.0.', __METHOD__), E_USER_DEPRECATED);
+
         $this->tableGenerators[] = $generator;
     }
 
@@ -85,6 +87,8 @@ public function addTable(callable $generator)
      */
     public function addPrefix($prefix)
     {
+        @trigger_error(sprintf('%s is deprecated and will be removed in version 4.0.', __METHOD__), E_USER_DEPRECATED);
+
         $this->prefix = $prefix;
     }
 }

src/Storage/Database/Schema/Manager.php

@@ -55,7 +55,7 @@ public function __construct(Application $app)
      */
     public function __call($name, $args)
     {
-        $this->app['logger.system']->warning('[DEPRECATED]: An extension called an invalid, or removed, integrity checker function: ' . $name, ['event' => 'deprecated']);
+        @trigger_error(sprintf('An extension called an invalid, or removed, integrity checker function: %s', $name), E_USER_DEPRECATED);
     }
 
     /**
@@ -65,7 +65,7 @@ public function __call($name, $args)
      */
     public function __get($name)
     {
-        $this->app['logger.system']->warning('[DEPRECATED]: An extension called an invalid, or removed integrity, checker property: ' . $name, ['event' => 'deprecated']);
+        @trigger_error(sprintf('An extension accessed an invalid, or removed, integrity checker property: %s', $name), E_USER_DEPRECATED);
     }
 
     /**

src/Storage/Database/Schema/Table/ContentType.php

@@ -153,6 +153,8 @@ private function columnDateTime($fieldName)
      */
     private function columnDecimal($fieldName)
     {
+        @trigger_error('The "decimal" field type is deprecated and will be removed in version 4.', E_USER_DEPRECATED);
+
         $this->table->addColumn($fieldName, 'decimal', ['precision' => '18', 'scale' => '9', 'default' => 0]);
     }
 

src/Storage/Entity/Content.php

@@ -79,6 +79,8 @@ public function set($key, $value)
      */
     public function getSortorder()
     {
+        @trigger_error(sprintf('%s is deprecated and will be removed in version 4.0.', __METHOD__), E_USER_DEPRECATED);
+
         return $this->sortorder;
     }
 
@@ -87,6 +89,8 @@ public function getSortorder()
      */
     public function setSortorder($sortorder)
     {
+        @trigger_error(sprintf('%s is deprecated and will be removed in version 4.0.', __METHOD__), E_USER_DEPRECATED);
+
         $this->sortorder = $sortorder;
     }
 
@@ -289,6 +293,8 @@ public function setTaxonomy(Collection\Taxonomy $taxonomy)
      */
     public function getGroup()
     {
+        @trigger_error(sprintf('%s is deprecated and will be removed in version 4.0.', __METHOD__), E_USER_DEPRECATED);
+
         return $this->group;
     }
 
@@ -297,6 +303,8 @@ public function getGroup()
      */
     public function setGroup($group)
     {
+        @trigger_error(sprintf('%s is deprecated and will be removed in version 4.0.', __METHOD__), E_USER_DEPRECATED);
+
         $this->group = $group;
     }
 

src/Storage/EntityManager.php

@@ -426,7 +426,8 @@ public function getLogger()
      */
     public function __call($method, $args)
     {
-        //$this->getLogger()->warning('[DEPRECATED] Accessing ['storage']->$method is no longer supported and will be removed in a future version.');
+        @trigger_error(sprintf("Accessing \$app['storage']->%s() is deprecated and will be removed in version 4.0.", $method), E_USER_DEPRECATED);
+
         return call_user_func_array([$this->legacy(), $method], $args);
     }
 
@@ -443,6 +444,8 @@ public function __call($method, $args)
      */
     public function getContent($textquery, $parameters = [], &$pager = [], $whereparameters = [])
     {
+        @trigger_error("Accessing \$app['storage']->getContent() is deprecated and will be removed in version 4.0.", E_USER_DEPRECATED);
+
         return $this->legacy()->getContent($textquery, $parameters, $pager, $whereparameters);
     }
 }

src/Storage/Field/Manager.php

@@ -31,21 +31,26 @@ public function __construct()
 
     public function addField(FieldInterface $field)
     {
+        @trigger_error(sprintf('%s is deprecated and will be removed in version 4.0. Use \Bolt\Storage\FieldManager instead.', __METHOD__), E_USER_DEPRECATED);
         $this->fields[$field->getName()] = $field;
     }
 
     public function addDummyField($field)
     {
+        @trigger_error(sprintf('%s is deprecated and will be removed in version 4.0. Use \Bolt\Storage\FieldManager instead.', __METHOD__), E_USER_DEPRECATED);
         $this->dummyFields[] = $field;
     }
 
     public function fields()
     {
+        @trigger_error(sprintf('%s is deprecated and will be removed in version 4.0. Use \Bolt\Storage\FieldManager instead.', __METHOD__), E_USER_DEPRECATED);
+
         return $this->fields;
     }
 
     public function getField($name)
     {
+        @trigger_error(sprintf('%s is deprecated and will be removed in version 4.0. Use \Bolt\Storage\FieldManager instead.', __METHOD__), E_USER_DEPRECATED);
         if ($this->has($name)) {
             return $this->fields[$name];
         } else {
@@ -55,6 +60,7 @@ public function getField($name)
 
     public function getDatabaseField($field)
     {
+        @trigger_error(sprintf('%s is deprecated and will be removed in version 4.0. Use \Bolt\Storage\FieldManager instead.', __METHOD__), E_USER_DEPRECATED);
         if (in_array($field, $this->dummyFields)) {
             return false;
         }
@@ -64,6 +70,8 @@ public function getDatabaseField($field)
 
     public function has($field)
     {
+        @trigger_error(sprintf('%s is deprecated and will be removed in version 4.0. Use \Bolt\Storage\FieldManager instead.', __METHOD__), E_USER_DEPRECATED);
+
         return isset($this->fields[$field]) || in_array($field, $this->dummyFields);
     }
 }