Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generated cookies_domain config is cached #6431

Closed
SvanteRichter opened this issue Feb 28, 2017 · 1 comment
Closed

Generated cookies_domain config is cached #6431

SvanteRichter opened this issue Feb 28, 2017 · 1 comment
Assignees
@CarsonF

Comments

@SvanteRichter
Copy link
Contributor

Currently if one does not set the cookies_domain option in the config it will be autogenerated from globals here, but it is then cached with the rest of the config too, which can lead to issues on multi-domain sites.

Assigning to @CarsonF per discussion on slack :)
@shyim
Copy link

shyim commented Feb 28, 2017

I had the problem before 2 weeks also. The answer from irc was its a feature and it doesent make sense when its empty.. :/

CarsonF added a commit to CarsonF/bolt that referenced this issue Mar 2, 2017
@CarsonF
Remove default value for cookies_domain. Fixes bolt#6431
89f5d13 
The only thing this did differently than PHP's default domain is removed
the www. prefix allowing the cookie to assigned to foo.com and www.foo.com.

It was decided this isn't a big enough use case to warrant keeping this logic.
Note that fixing this caching bug would mean moving the logic to 3 different
places (or 2 with larger refactoring).
@CarsonF CarsonF mentioned this issue Mar 2, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CarsonF CarsonF

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@CarsonF @SvanteRichter @shyim