Remove default value for cookies_domain #6440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only thing this did differently than PHP's default domain is removed the www. prefix allowing the cookie to assigned to foo.com and www.foo.com. It was decided this isn't a big enough use case to warrant keeping this logic. Note that fixing this caching bug would mean moving the logic to 3 different places (or 2 with larger refactoring).
bobdenotter
approved these changes
Mar 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6431
The only thing this did differently than PHP's default domain is removed
the
www.prefix allowing the cookie to assigned tofoo.comandwww.foo.com.It was decided this isn't a big enough use case to warrant keeping this logic.
Note that fixing this caching bug would mean moving the logic to 3 different
places (or 2 with larger refactoring).