Deprecated ResourceManager Completely #6439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…abstraction for listTemplates twig function.
…odebase aren't coupled to it.
…ning twig files for translations. Yes I just said this shouldn't be done. It will be removed with translation refactor in 3.4.
…ead of with ResourceManager setup. I still hate this check, the config file is supposed to be optional.
…pending on them. This allows us to call "filesystem" whenever we want without fear of infinite loop. Merged other filesystem DI keys back into main filesystem key. The theme path is also added to Twig loader at boot now as well to match and reset its internal error cache if some dummy tries to render a theme template before boot.
…d of ResourceManager. Yes, this adds side effects...will be scrapped with Config refactor soon.
…reated while cache is still valid.
…ocal adapter / mocks. Also asserting package names.
…urrentTimestamp, and getWhichEnd
…. "view" was before "bolt_assets" which meant "view" value was ignored.
|
Before merging this, I would like to extend a very public "thank you" to @rossriley who originally authored
Bolt has grown as a platform considerably since then, and for quite a while now RM has needed to be replaced for a bunch of reasons that do not matter past "we want to make Bolt better, more powerful, and more flexible." The functionality introduced in this PR marks the end of an era in a way, so 🍻 for all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the remaining usages of
ResourceManagerand adds a ton of deprecation notices.I know this is late to be in 3.3. This would be best grouped in this release, because
PathResolverhas been added andResourceManagerhas had most of its usage removed and deprecated.The only other notable change in this PR is 1b19486. The
themefilesystem is added tofilesystemservice at boot, instead of when the object is created. This allows thefilesystemservice to be accessed whenever, without fear of an infinite loop. The Twig loader was also changed to add the theme path at boot since it now doesn't exist before that point.