[3.3][Tests] Extension coverage #6521
Conversation
GwendolenLynch
changed the title
| */ | ||
| protected function registerServices(Application $app) | ||
| { | ||
| $this-> extendDatabaseSchemaServices(); |
| parent::setUpBeforeClass(); | ||
| $fs = new Filesystem(); | ||
| $fs->copy(PHPUNIT_ROOT . '/resources/test.twig', PHPUNIT_WEBROOT . '/theme/base-2016/test.twig', true); | ||
| } |
There was a problem hiding this comment.
Can you just add an Array_Loader to the Twig_Loader_Chain for that render test?
The less files we have to copy around the better.
|
@CarsonF: Updated |
|
"Calback" <- missing second Not thrilled about the defined constant usage but I'll let it slide. You should also render with sandbox enabled so Is |
Fixed
Makes at least two of us
Done
Yes |
Why do you not want to use ArrayLoader then? |
Fine, done 😜 |
| { | ||
| return [ | ||
| 'koala', | ||
| 'dropbear' => ['position' => 'prepend', 'namespace' => 'Marsupial'], |
There was a problem hiding this comment.
A lack of exceptions
There was a problem hiding this comment.
Sure, but it is more than we have, and I have very little desire/allowance time to work on tests, and am trying to turn a few quick PRs over to move a few things along … with the hope it makes it easier for others to help.
There was a problem hiding this comment.
with the hope it makes it easier for others to help.
Plus Twig internals and writing tests, just sayin' 😉
There was a problem hiding this comment.
I gave in, and added the tests … You owe me a merge now!
| Filter dropbear {{ name|dropbear }} | ||
| TWIG; | ||
| $loader = new ArrayLoader(['marsupial.twig' => $template]); | ||
| $app['twig']->setLoader($loader); |
There was a problem hiding this comment.
Just also had the thought that you could set this with $app['twig.templates'] instead of creating an ArrayLoader directly.
There was a problem hiding this comment.
Yeah, but I CBF iterating test to perfection … they're tests, better things to focus on.
|
I am … over to you @bobdenotter |
CarsonF
modified the milestones:
Bolt 3.3 - Feature release,
Bolt 3.2 - Feature release
|
|
No description provided.