Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.3][Tests] Silex2 deprecations #6564

Merged
merged 4 commits into from
Apr 10, 2017
Merged

[3.3][Tests] Silex2 deprecations #6564

merged 4 commits into from
Apr 10, 2017

Conversation

GwendolenLynch
Copy link
Contributor

@GwendolenLynch GwendolenLynch commented Apr 10, 2017

In Pimple v3, once the container element has been accessed, it is "frozen" to change

e.g.

$app = new \Pimple\Container();

$app['koala'] = 'drop bear';
$value = $app['koala'];

// This will now throw an exception
$app['koala'] = 'kenny';

This is Phase I of getting tests in order 馃槈

@GwendolenLynch GwendolenLynch added this to the Bolt 3.3 - Feature release milestone Apr 10, 2017
Copy link
Member

@bobdenotter bobdenotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool stuff! 馃憤

@bobdenotter bobdenotter merged commit 3f6df1e into bolt:release/3.3 Apr 10, 2017
@GwendolenLynch GwendolenLynch deleted the tests/silex2-deprecations branch April 11, 2017 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants