Fix content changelog field handling #6565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GwendolenLynch
force-pushed
the
fix/content-changelog-field-handling
branch
from
2a958a3
to
704482d
Compare
GwendolenLynch
approved these changes
Apr 11, 2017
|
any chance of merging this into 3.4 when you get a chance too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure exactly where the bug starts manifesting itself but sometimes the changelog will record a diff for relation and taxonomy fields, even if there are no taxonomy or relations set on a contenttype.
The root cause of this was that the metadata for the field was not set on the LogChange entity although it was expecting the property to be available.
This fixes that issue by injecting the metadata into the entity object after it has been fetched in the Repository.
If the field is not then set, the transformation will be skipped.
I've tested this on 3.3 and 3.4 and this seems to work.