Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.3][Deprecation] Use Request::isMethodSafe() according to standard #6701

Merged
merged 1 commit into from
May 24, 2017
Merged

[3.3][Deprecation] Use Request::isMethodSafe() according to standard #6701

merged 1 commit into from
May 24, 2017

Conversation

GwendolenLynch
Copy link
Contributor

According to standard in RFC7231

Of the request methods defined by this specification, the GET, HEAD,
OPTIONS, and TRACE methods are defined to be safe.

So Symfony have deprecated its use in 3.2 without a parameter to indicate spec, or BC.

… just keeping master quiet 😉

@GwendolenLynch GwendolenLynch added this to the Bolt 3.3 - Feature release milestone May 23, 2017
bobdenotter
bobdenotter approved these changes May 24, 2017
View reviewed changes
Copy link
Member

@bobdenotter bobdenotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@bobdenotter bobdenotter merged commit 8695285 into bolt:release/3.3 May 24, 2017
@GwendolenLynch GwendolenLynch deleted the deprecation/symfony3-request branch May 24, 2017 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobdenotter bobdenotter bobdenotter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Bolt 3.3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@GwendolenLynch @bobdenotter