More descriptive exception when the bundled-extension class does not exist #6839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nitpick-CI
reviewed
Jul 20, 2017
src/Bootstrap.php
Outdated
| @@ -158,6 +158,9 @@ public static function run($rootPath) | |||
| 'extensions', | |||
| function ($extensions) use ($config) { | |||
| foreach ((array) $config['extensions'] as $extensionClass) { | |||
| if(! class_exists($extensionClass) ) { | |||
There was a problem hiding this comment.
- Expected 1 space after IF keyword; 0 found
- Expected 0 spaces before closing bracket; 1 found
|
fixes #6836 |
lenvanessen
changed the title
GwendolenLynch
suggested changes
Jul 20, 2017
src/Bootstrap.php
Outdated
| @@ -158,6 +158,9 @@ public static function run($rootPath) | |||
| 'extensions', | |||
| function ($extensions) use ($config) { | |||
| foreach ((array) $config['extensions'] as $extensionClass) { | |||
| if(! class_exists($extensionClass) ) { | |||
| throw new LogicException("$extensionClass is defined in bolt.yml, but class is misspelled or is not loaded by composer"); | |||
| } | |||
There was a problem hiding this comment.
This will throw exceptions for instantiated classed.
Bundles are expert level, from the beginning by design, this is out of scope
|
Reopening, as now I have more time to reply (plus what I mentioned in Slack), lets get this over the line. My reply was too terse 😆 I can do some magic for you to get this where it needs to be, or grab me again in Slack and lets go over it with more detail 👍 |
Nitpick-CI
reviewed
Jul 22, 2017
src/Bootstrap.php
Outdated
| @@ -165,13 +165,16 @@ public static function run($rootPath) | |||
| function ($extensions) use ($config) { | |||
| foreach ((array) $config['extensions'] as $extensionClass) { | |||
| if (is_string($extensionClass)) { | |||
| if(!class_exists($extensionClass)) { | |||
There was a problem hiding this comment.
Expected 1 space after IF keyword; 0 found
GwendolenLynch
previously approved these changes
Jul 22, 2017
GwendolenLynch
approved these changes
Jul 22, 2017
|
As mentioned in Slack, I've rebased the branch to pull in the tests from #6844 and tweaked the location of the check, plus added a test for it. Catch you when you're back 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A class thatt doesn't exist can't implement an interface, so this should be checked first.