Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.4] File manager improvements #6898

Merged
merged 7 commits into from
Aug 20, 2017

Conversation

lenvanessen
Copy link
Contributor

Fixes:
#6758, #2263

Currently:

  • Transforms body into dropzone for file uploads + adds dropzone hint on drop-event
  • Moves event-handling handling outside of twig templates
  • Improves the lay-out by moving the buttons to the right, instead of the bottom
  • Lazy loads images, instead of pulls every thumbnail in when loading the page
  • Adds search to the filemanager page

Test away!

@GwendolenLynch GwendolenLynch added this to the Bolt 3.4 - Feature release milestone Aug 15, 2017
@GwendolenLynch GwendolenLynch changed the title Feature/filemanager improvements [3.4] File manager improvements Aug 15, 2017
@GwendolenLynch GwendolenLynch force-pushed the feature/filemanager-improvements branch from 1d74d2c to f99c627 Compare August 19, 2017 08:07
CarsonF
CarsonF previously approved these changes Aug 19, 2017
Copy link
Member

@CarsonF CarsonF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good! Great job man 👍

@@ -12,7 +12,7 @@

<tbody>
{% for file in context.files %}
<tr>
<tr class="entry" data-bolt-browse-name="{{ file.filename|excerpt(80)|shy | trim }}">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think any of these filters are needed.
Why limit the filename?
The |shy filter isn't needed as this is data not display text.
The |trim filter isn't needed as filenames cannot contain spaces.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why limit the filename?

I believe this came down to a the way BUIC handles things currently.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not see this earlier, sorry about that.
Currently the filename itself is trimmed down in the display, for BUIC as wel as the filemanager.

It comes down to this, if the filename in the data-attribute would be the original (if longer than 80), than you'd get an inconsitancy in the display, the marking, and the search.

If you'd copy paste a filename in that is longer than 80 chars it would be found, but not marked.

If we'd remove the trim, we should also remove it for the display, so they are consistent. Simply left it there because I don't know why it was put in in the first place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants