-
-
Notifications
You must be signed in to change notification settings - Fork 810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.4] File manager improvements #6898
[3.4] File manager improvements #6898
Conversation
1d74d2c
to
f99c627
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good! Great job man 👍
app/view/twig/files/_files.twig
Outdated
@@ -12,7 +12,7 @@ | |||
|
|||
<tbody> | |||
{% for file in context.files %} | |||
<tr> | |||
<tr class="entry" data-bolt-browse-name="{{ file.filename|excerpt(80)|shy | trim }}"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think any of these filters are needed.
Why limit the filename?
The |shy
filter isn't needed as this is data not display text.
The |trim
filter isn't needed as filenames cannot contain spaces.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why limit the filename?
I believe this came down to a the way BUIC handles things currently.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did not see this earlier, sorry about that.
Currently the filename itself is trimmed down in the display, for BUIC as wel as the filemanager.
It comes down to this, if the filename in the data-attribute would be the original (if longer than 80), than you'd get an inconsitancy in the display, the marking, and the search.
If you'd copy paste a filename in that is longer than 80 chars it would be found, but not marked.
If we'd remove the trim, we should also remove it for the display, so they are consistent. Simply left it there because I don't know why it was put in in the first place.
f99c627
to
f7ceb86
Compare
Fixes:
#6758, #2263
Currently:
Test away!