Fixes for title_format
#7067
Merged
Fixes for title_format
#7067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only if you haven't got legacy storage disabled 😉 |
GwendolenLynch
force-pushed
the
hotfix/title_format
branch
from
809540b
to
a490b4b
Compare
GwendolenLynch
approved these changes
Oct 11, 2017
This was referenced Oct 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6870. Fixes #7064.
This PR makes
title_formatwork for the new storage layer, as it did for the old one. The code inContentTypeTitleTrait::getTitleColumnNamesis mostly adapted fromContentValuesTrait::getTitleColumnName.I also modified the old implementation in
ContentValuesTrait, to fix #6870 for places where the old storage layer is used. (like in the "Last modified" block in the right aside.