ksort the repeater hydrate to ensure grouping order is maintained #7253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobdenotter
previously approved these changes
Dec 13, 2017
There was a problem hiding this comment.
Monkey-tests show this fix is doing what it should for me.. Didn't merge in yet, because of failing tests (which is addressed in #7254) 👍
GwendolenLynch
force-pushed
the
fix/updating-block-collections
branch
from
9d3eee5
to
9a11566
Compare
GwendolenLynch
approved these changes
Dec 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully fixes #7248
Some mysql versions seem not to pull these out in the correct order (and I think it might be the case in SQLite too) so just to make sure we sort the fetched values by the grouping number to make sure they are rendered in the correct order.