Set preserve_keys in array_slice to keep numeric array key association #7531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nitpick-CI
reviewed
Jun 16, 2018
src/Form/Resolver/Choice.php
Outdated
| $ind = 0; | ||
| foreach ($field->get('values', []) as $key => $value) { | ||
| if ($limit !== null) { | ||
| if ($ind > $limit) |
There was a problem hiding this comment.
Inline control structures are not allowed
GwendolenLynch
suggested changes
Jun 16, 2018
| @@ -105,7 +105,19 @@ private function getValues(array $field) | |||
| */ | |||
| private function getYamlValues(Bag $field) | |||
| { | |||
| $values = array_slice($field->get('values', []), 0, $field->get('limit')); | |||
There was a problem hiding this comment.
You just need to add true as the 4th parameter to array_slice() to do natively what you're recreating below 😉
$values = array_slice($field->get('values', []), 0, $field->get('limit'), true);
There was a problem hiding this comment.
yay! 😀
(actually, in such situations i dislike all those complex polymorphic functions)
|
@GawainLynch thank you for help. And for test. |
GwendolenLynch
approved these changes
Jun 16, 2018
GwendolenLynch
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7411
In
Form\Resolve\Choice.phparray_sliceclears indices of original associative array.