Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove index.php from URL. Credit @cdowdy #5605 #15

Merged
merged 1 commit into from
Aug 29, 2016

Conversation

GwendolenLynch
Copy link
Contributor

As per discussion in bolt/bolt#5605 this ports changes from core, in preparation for it's upcoming diet.

@GwendolenLynch GwendolenLynch merged commit d17509f into master Aug 29, 2016
@GwendolenLynch GwendolenLynch deleted the move-htaccess branch August 29, 2016 06:55
@@ -9,7 +9,7 @@ Options -Indexes
Options -MultiViews
</IfModule>

<FilesMatch "\.(dist|db|markdown|md|twig|yaml|yml)$">
<FilesMatch "\.(dist|db|markdown|md|twig|yaml|yml)|(bower|composer|jsdoc|package)\.json$">
<IfModule mod_authz_core.c>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those aren't in the web root...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for the files that are: bower.json, package.json and theme.yml are often in the theme/ folder.

Also, if someone messes with their site structure, this still applies.

Copy link
Member

@CarsonF CarsonF Aug 29, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah interesting...let me think about that.

As for people messing with their structure, that's fine, but we don't need to support that here. This repo should have the minimum needed for the standard structure.

Copy link
Contributor Author

@GwendolenLynch GwendolenLynch Aug 29, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As for people messing with their structure, that's fine, but we don't need to support that here. This repo should have the minimum needed for the standard structure.

Yes, I have to agree (again) that this probably isn't the place for it. One problem is that when adjusting the structure, there should be a bunch of things that are "must be" checked, and this is just one.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The thing is, people who mess with the structure, are usually kludging their way around not being able to configure their webserver properly. These people will usually not be technically proficient enough to review their .htaccess file for best practices. I say we leave this in, for those people.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. I don't like it, but that is a fair point. I'll let it rest :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants