Merge pull request #1018 from bolt/bugfix/replace-illegal-icon-tag

Replace <icon> with <i> in infobox popover icon
bolt · Feb 5, 2020 · e02106b · e02106b
2 parents 2361524 + 68d6341
commit e02106b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/templates/_partials/fields/_label.html.twig b/templates/_partials/fields/_label.html.twig
@@ -13,7 +13,7 @@
         {% if required %} <span class="required-label"></span> {% endif %}
 
         {% if info is not empty %}
-            <icon class="fa fa-info-circle" data-toggle="popover" data-trigger="hover" title="{{ label }}" data-html="true" data-content="{{ info }}"></icon>
+            <i class="fa fa-info-circle" data-toggle="popover" data-trigger="hover" title="{{ label }}" data-html="true" data-content="{{ info }}"></i>
         {% endif %}
     </label>
 {%- endif -%}
diff --git a/tests/e2e/edit_record_1.feature b/tests/e2e/edit_record_1.feature
@@ -61,10 +61,10 @@ Feature: Edit record
     When I am on "/bolt/edit/38"
 
     Then I should see an "label[for='field-email']" element
-    And I should see 1 "icon" elements in the "label[for='field-email']" element
+    And I should see 1 "i" elements in the "label[for='field-email']" element
 
     When I scroll "Email" into view
-    When I hover over the "label[for='field-email'] > icon" element
+    When I hover over the "label[for='field-email'] > i" element
     Then I should see "Email" in the ".popover-header" element
     And I should see "This is an info box shown as a popover next to the field label." in the ".popover-body" element