Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing attributes in records|json_records #407

Closed
bobdenotter opened this issue Apr 19, 2019 · 4 comments
Closed

Missing attributes in records|json_records #407

bobdenotter opened this issue Apr 19, 2019 · 4 comments
Assignees
Milestone

Comments

@bobdenotter
Copy link
Member

@bobdenotter bobdenotter commented Apr 19, 2019

After the introduction of #400, a few things are not displayed correctly in the backend. Namely this:

Schermafbeelding 2019-04-19 om 18 00 05
Schermafbeelding 2019-04-19 om 18 00 16

The Vue component that breaks is assets/js/app/listing/Components/Table/Row/_Meta.vue.

Especially these values:

{{ record.author.displayName }} -> can be replaced by {{ record.authorName }}

These two should be added:

  • {{ record.icon }} -> which is coming from the icon_one from the contenttype definition
  • {{ record.status }} -> Which is the current status of the record.
@JarJak
Copy link
Member

@JarJak JarJak commented Apr 19, 2019

Are there some values of record that are not used in backend zone?

Loading

@bobdenotter
Copy link
Member Author

@bobdenotter bobdenotter commented Apr 19, 2019

I think they all are, at some time.. Some like depublishedAt is not shown yet, but it will be in the contextual menu on the overview pages. So I think it should match what was in the old one at https://github.com/bolt/four/pull/400/files#diff-af5de60a97e3b51d356ac8b4647b2c95L54

Loading

@bobdenotter
Copy link
Member Author

@bobdenotter bobdenotter commented Apr 19, 2019

addition: author/id and author/email are not needed.

Loading

@JarJak
Copy link
Member

@JarJak JarJak commented Apr 19, 2019

Can this one wait for #332? Because a lot of things about Vue components will need to follow up there and things will break.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants