Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/limit collection #1019

Merged
merged 1 commit into from Feb 5, 2020
Merged

Feature/limit collection #1019

merged 1 commit into from Feb 5, 2020

Conversation

I-Valchev
Copy link
Member

No description provided.

@I-Valchev I-Valchev mentioned this pull request Feb 5, 2020
Closed
5 tasks
bobdenotter
bobdenotter approved these changes Feb 5, 2020
View reviewed changes
Copy link
Member

@bobdenotter bobdenotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine for now, but I'm positive we'll soon get a request for "I don't want to set a maximum, but i do want a minimum number of items!".. But, we'll deal with that when we get there. :-)

@bobdenotter bobdenotter merged commit ca618dd into master Feb 5, 2020
@bobdenotter bobdenotter deleted the feature/limit-collections branch February 5, 2020 18:44
@I-Valchev
Copy link
Member Author

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobdenotter bobdenotter bobdenotter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@I-Valchev @bobdenotter