Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update webpack encore #2752

Merged
merged 8 commits into from
Aug 6, 2021
Merged

Update webpack encore #2752

merged 8 commits into from
Aug 6, 2021

Conversation

nestordedios
Copy link
Collaborator

Fixes #2578 .

This PR updates Webpack Encore from v0.31 to v1.5.

The downside of this upgrade is that when running npm run build we get a lot of warning messages in the console like:

: Using / for division is deprecated and will be removed in Dart Sass 2.0.0.

Recommendation: math.div($spacer, 2)

More info and automated migrator: https://sass-lang.com/d/slash-div

   ╷
15 │   padding: $spacer / 2;
   │            ^^^^^^^^^^^
   ╵
    assets/scss/vendor/api-platform.scss 15:12  @import
    assets/scss/vendor/vendor.scss 2:9          @import
    assets/scss/bolt.scss 3:9                   root stylesheet

: Using / for division is deprecated and will be removed in Dart Sass 2.0.0.

Recommendation: math.div($spacer, 2)

More info and automated migrator: https://sass-lang.com/d/slash-div

    ╷
302 │ $headings-margin-bottom:      $spacer / 2 !default;
    │                               ^^^^^^^^^^^
    ╵
    node_modules/bootstrap/scss/_variables.scss 302:31  @import
    assets/scss/themes/_bootstrap.scss 2:9              @import
    assets/scss/themes/dark.scss 39:9                   root stylesheet

: Using / for division is deprecated and will be removed in Dart Sass 2.0.0.

Recommendation: math.div($spacer, 2)

More info and automated migrator: https://sass-lang.com/d/slash-div

npm-run-build

@bobdenotter
Copy link
Member

Thanks, @nestordedios 👍

The downside of this upgrade is that when running npm run build we get a lot of warning messages in the console like:

We were getting these already! They need to be fixed, but that can/should be done in a separate PR!

@nestordedios
Copy link
Collaborator Author

You are welcome @bobdenotter .

I wasn't aware of that.

I think it's Bootstrap the one making so much noise.

In the Bootstrap repository they seem to have this issue and they suggest to downgrade sass to v1.32.* twbs/bootstrap#34051 (comment) but I don't think this is what we really want.

It seems it is fixed for Bootstrap v5 but not for v4. Maybe it will get fix for Bootstrap v4 as well twbs/bootstrap#34245 (comment). Let's keep an eye on it.

@bobdenotter
Copy link
Member

Or, alternatively, see if we can update to Bootstrap 5.1 soon-ish. 👍 (but, both can come in follow-up PR's)

Copy link
Member

@bobdenotter bobdenotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@bobdenotter bobdenotter merged commit 639afb9 into 4.2 Aug 6, 2021
@bobdenotter bobdenotter deleted the update-webpack-encore branch August 6, 2021 11:55
@nestordedios
Copy link
Collaborator Author

Nice!!

Yes I'll look into Bootstrap migration and open a separate PR for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

We need to update symfony/webpack-encore
2 participants