Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add YAML Migrations #3497

Merged
merged 4 commits into from
Dec 22, 2023
Merged

Conversation

xiaohutai
Copy link
Member

@xiaohutai xiaohutai commented Oct 26, 2023

See for the diff: https://gist.github.com/xiaohutai/b5f44fec671cfff6691255354f6f769b

Not sure if the uncommented canonical: https://example.org was intentional.

Need to test the integrations before merging in.

@bobdenotter
Copy link
Member

bobdenotter commented Oct 30, 2023

@xiaohutai
Copy link
Member Author

I found the one for for doctrine.yaml: #2088

Not sure if 5.1.6 is still the correct version here, but it seems the existing config in 5.1 already has it added: https://github.com/bolt/core/blob/5.1/config/packages/doctrine.yaml#L35C2-L35C21 (Ideally this migration should've been added with the config change 😋)

I've added those, but the bolt/core doesn't have the cache.app so I changed it in this commit as well.

@xiaohutai xiaohutai changed the title [WIP] Add YAML Migrations Add YAML Migrations Nov 9, 2023
Copy link
Member

@bobdenotter bobdenotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoop! 👍

@bobdenotter bobdenotter merged commit 0f7a155 into bolt:master Dec 22, 2023
16 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants