Allow for caching of widgets #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JarJak
requested changes
May 10, 2019
src/Widget/CacheTrait.php
Outdated
| $this->key = $this->createKey(); | ||
| } | ||
|
|
||
| public function cachedInvoke(): string |
There was a problem hiding this comment.
can't this method just overwrite __invoke() ?
There was a problem hiding this comment.
I'm going to try something else to make it more elegant.
Overriding it would be nice, but won't work in this case. A trait can override methods from the base (extended) class, but then there's no such thing as a ::parent.
JarJak
requested changes
May 10, 2019
JarJak
approved these changes
May 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes a big difference, especially for widgets like 'news'...
Before:
After: