Headline | Docs | Testing and Documentation for Headline Component #1210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @mikemai2awesome - can you review this? Some questions in the PR. |
joekarasek
reviewed
Jun 18, 2019
joekarasek
reviewed
Jun 18, 2019
joekarasek
reviewed
Jun 18, 2019
joekarasek
reviewed
Jun 18, 2019
joekarasek
reviewed
Jun 18, 2019
joekarasek
reviewed
Jun 18, 2019
joekarasek
reviewed
Jun 18, 2019
joekarasek
reviewed
Jun 18, 2019
joekarasek
suggested changes
Jun 18, 2019
There was a problem hiding this comment.
@TashaBasalt Good work. Lets go through the TESTING.md with a fine tooth comb with an eye for "how to describe this for someone with minimal technical expertise" and for typos.
joekarasek
changed the title
TashaBasalt
changed the title
mikemai2awesome
requested changes
Jun 19, 2019
Just adding here that the quotes should be present.
|
@joekarasek @TashaBasalt just checking in -- what's the status on this one? |
|
@sghoweri We're still waiting on confirmation for whether or not to have the TESTING.md describe a successful function that isn't actually functional. |
joekarasek
approved these changes
Jul 1, 2019
|
@sghoweri @mikemai2awesome This is now ready for final review/merge.
|
mikemai2awesome
approved these changes
Jul 12, 2019
|
Thanks guys!! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira
http://vjira2:8080/browse/BDS-986
Summary
Adding Jest Snapshot tests of headline component and a TESTING.md file.
Details
Added tests to cover various combinations of font sizes and weights, but I'm not sure that amount of specificity is required. There is also a 'quoted' example of text in the Bolt Pattern Lab, but the sample text isn't actually quoted in any way. Is that an error?
How to test
yarn test:js