Placeholder | Docs | Testing and Documentation for Placeholder component #1215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joekarasek
changed the title
joekarasek
reviewed
Jun 20, 2019
joekarasek
reviewed
Jun 20, 2019
margoromo
assigned danielamorse, sghoweri and adamszalapski and unassigned danielamorse, sghoweri and adamszalapski
mikemai2awesome
approved these changes
Jun 25, 2019
adamszalapski
approved these changes
Jun 26, 2019
There was a problem hiding this comment.
Looking good, all tests passing. Good job @TashaBasalt. I re-run the tests and now they pass :)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira
http://vjira2:8080/browse/BDS-943
Summary
Adding Jest snapshot tests to the Placeholder component and a TESTING.md file
Details
Wrote and ran Jest snapshot tests for the different Placeholder variations and included testing instructions in the TESTING.md
How to test
yarn test:js