Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block-list | Docs | Testing and documentation for block-list component #1222

Merged
merged 2 commits into from Jun 26, 2019

Conversation

TashaBasalt
Copy link
Contributor

@TashaBasalt TashaBasalt commented Jun 21, 2019

Jira

http://vjira2:8080/browse/BDS-978

Summary

Jest testing block-list component

Details

Adding Jest snapshot tests to the block-list component as well as adding a TESTING.md file

How to test

yarn test:js

Copy link
Contributor

@joekarasek joekarasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Contributor

@sghoweri sghoweri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @TashaBasalt!

@sghoweri sghoweri merged commit 88a4cd6 into master Jun 26, 2019
@sghoweri sghoweri deleted the feature/block-list branch June 26, 2019 11:15
@sghoweri sghoweri mentioned this pull request Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants