Code-snippet | Bug | Fix for code-snippet component to correct work without JS #1224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/bolt into feature/code-snippets
adamszalapski
changed the title
mikemai2awesome
approved these changes
Jun 25, 2019
sghoweri
approved these changes
Jul 1, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira
http://vjira2:8080/browse/BDS-1479
Summary
Update twig version of code-snippet to be consistent with JS version.
Details
(Explain the changes in enough detail fo reviewers to understand. Raise any questions for reviewers to consider.)
How to test
Run this code locally. Go to
code-snippetpage and test behavior by disabling and enabling of JS on specific subpages. Only differences in both versions should be syntax highlighting.####TWIG version:
####JS version: