Fix: typo in image modal's caption markup #1225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Jira N/A ## Summary Fixed a typo in the image modal caption's markup that causes the caption text to not render. ## Details `slot="footer"` was accidentally used on the figcaption container, which is a goof from an older mockup. ## How to test Run the branch locally and make sure image modal examples have captions.
|
@mikemai2awesome I'm all for getting as many eyes on a PR as we can but for super simple PRs like this, only one code reviewer is really needed. 😉 |
|
Verified fix working as expected - thanks @mikemai2awesome! |
sghoweri
approved these changes
Jul 1, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira
N/A
Summary
Fixed a typo in the image modal caption's markup that causes the caption text to not render.
Details
slot="footer"was accidentally used on the figcaption container, which is a goof from an older mockup.How to test
Run the branch locally and make sure image modal examples have captions.