Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add type checking of JS using TypeScript #1234

Merged
merged 1 commit into from Jul 1, 2019

Conversation

EvanLovely
Copy link
Contributor

@EvanLovely EvanLovely commented Jun 27, 2019

This add type checking (not compiling) of JS files using TypeScript via yarn test:types. Currently there are a lot of errors coming in and fine tuning the includes and excludes properties in tsconfig.json would be a good start to narrow the focus would be a good idea. The big advantage from this is much better editor auto-completion.

@EvanLovely EvanLovely requested a review from sghoweri June 27, 2019 17:31
@sghoweri
Copy link
Contributor

sghoweri commented Jul 1, 2019

Thanks @EvanLovely!!

@sghoweri sghoweri merged commit b306fb5 into master Jul 1, 2019
@sghoweri sghoweri deleted the feature/type-checking branch July 1, 2019 11:56
@sghoweri sghoweri mentioned this pull request Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants