Button | Twig | Add missing 'target' attribute #1266
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira
http://vjira2:8080/browse/BDS-1415
Summary
Added
target
to Twig-rendered button-style link if passed in via attributes.Details
Currently the way to add a
target
to a button is to pass it in via Twigattributes
. This adds the prop to the custom element but not the inner semantic<a>
, so you have to wait until the JS kicks in for it to be added. This PR adds it to the Twig-rendered markup so that it works with and without JS.Note: the button schema needs to be updated to include
url
andtarget
. This will be handled in a separate ticket.How to test
fix/button-missing-target
branch locally.