Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typography | Docs | Map typography tokens to JSON data #1785

Merged
merged 12 commits into from
Mar 31, 2020

Conversation

sghoweri
Copy link
Contributor

@sghoweri sghoweri commented Mar 16, 2020

Jira

http://vjira2:8080/browse/BDS-2044

Summary

Updates typography doc page to be dynamic and evergreen.

Details

  1. Created JSON maps for font-family and font-size.
  2. Used said maps to generate token tables.
  3. Added a @todo in the code for doing the same to font-weight later, currently that map is a mess and it's better to manually write out the options for now.

How to test

Run the branch locally and proof read the typography doc page.

@mikemai2awesome mikemai2awesome changed the title Expose design token data for font size options + breakpoint-specific font size bases Typography | Docs | Map typography tokens to JSON data Mar 18, 2020
@mikemai2awesome mikemai2awesome self-assigned this Mar 18, 2020
@mikemai2awesome mikemai2awesome added this to the v2.20.1 milestone Mar 18, 2020
@mikemai2awesome mikemai2awesome marked this pull request as ready for review March 18, 2020 21:53
Copy link
Collaborator

@adamszalapski adamszalapski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work.

@sghoweri sghoweri modified the milestones: v2.20.1, v2.21.0 Mar 26, 2020
Copy link
Collaborator

@danielamorse danielamorse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice docs! Well-written/organized. Good use of Tabs and Tooltip.

Build is failing: https://travis-ci.com/github/boltdesignsystem/bolt/jobs/300420438

Ok to merge once build passes.

@sghoweri sghoweri merged commit 009fe40 into master Mar 31, 2020
@sghoweri sghoweri deleted the feature/font-size-design-token-data branch March 31, 2020 19:40
@sghoweri
Copy link
Contributor Author

sghoweri commented Apr 8, 2020

PR was released with v2.21.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants