Prevent empty href attribute on web component version of bolt-link
#1788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sghoweri
approved these changes
Mar 24, 2020
There was a problem hiding this comment.
Thanks @adamszalapski! +1 on the new tests added 💯
This work also (indirectly) relates to work I'm doing with re-rendering Link / Button, etc when props like url change, however this should be safe to merge down as is. 👍
|
PR was released with v2.21.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira
http://vjira2:8080/browse/BDS-1921
Summary
Fix the issue and write a test to check this.
How to test
Run this code locally. Add
bolt-linkweb component version withouturlprop or provide content withouthrefattribute like:<bolt-link>Link without URL prop</bolt-link>or<bolt-link><a target="_blank">Link without href</a></bolt-link>and check if you clikc on that link page will reload.You can inspect if
hrefis added to the content insidebolt-linkThis is a small fix and i think that only one approve is enough to merge it.