Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix: Fix for Composer Install Issues on Travis #1793

Merged
merged 4 commits into from
Mar 25, 2020

Conversation

sghoweri
Copy link
Contributor

Jira

http://vjira2:8080/browse/BDS-2075

Summary

Updates composer dependencies to work around a Composer install issue that just started to pop up on Travis.

Details

I'm not 100% sure on this but I think this fix works because one or more of the following (but probably the first two bullets here):

  • We're no longer referencing some older composer dependencies (ex. update Twig to 1.42.5)
  • We're switching to using the stable channel instead of the dev channel
  • All Github repos referenced have the no-api flag added
  • We removed the no-longer-needed Github repo reference to https://github.com/drupal/core-render

How to test

Confirm Travis CI build passes as expected

@remydenton
Copy link
Collaborator

remydenton commented Mar 25, 2020

Yay, looks like it works!

A couple thoughts:

  • Why are we using ${GH_TOKEN} here instead of ${GITHUB_TOKEN} like the rest of the travis.yml file? What is even the difference between those two?
  • Can we back out the changes that didn't make a difference before merging?

@remydenton
Copy link
Collaborator

As discussed on Slack, this is OK to ship with the earlier changes since composer.lock files don't affect downstream dependencies. Thanks @sghoweri for updating the token.

@sghoweri
Copy link
Contributor Author

Thanks @remydenton!

@sghoweri
Copy link
Contributor Author

sghoweri commented Apr 8, 2020

PR was released with v2.21.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants