Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: accordion open prop typo in web component demo #1809

Merged
merged 1 commit into from
Apr 8, 2020

Conversation

mikemai2awesome
Copy link
Collaborator

Jira

N/A

Summary

Fixes a typo on the Accordion web component demo page.

How to test

Run the branch locally and check the Accordion web component demo page, make sure the open prop is named open not auto-open on the accordion item.

@mikemai2awesome mikemai2awesome added this to the v2.21.0 milestone Apr 3, 2020
@mikemai2awesome mikemai2awesome changed the title Fix: open prop typo in web component demo Fix: accordion open prop typo in web component demo Apr 4, 2020
@sghoweri sghoweri added the minor label Apr 8, 2020
@sghoweri sghoweri self-requested a review April 8, 2020 17:51
Copy link
Contributor

@sghoweri sghoweri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thanks @mikemai2awesome!

@sghoweri sghoweri merged commit 9286cb9 into master Apr 8, 2020
@sghoweri sghoweri deleted the fix/accordion-doc-typo branch April 8, 2020 17:52
@sghoweri
Copy link
Contributor

sghoweri commented Apr 8, 2020

PR was released with v2.21.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants