-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Update Mission Modal Blueprint w/ new (WIP) Rating component #1813
Conversation
…-color function instead
@@ -11,10 +11,17 @@ bolt-card-replacement-background { | |||
right: 0; | |||
bottom: 0; | |||
left: 0; | |||
z-index: 1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sghoweri this is going to break the z-index management in here. Instead, can you try this? I have this working locally:
bolt-card-replacement-background {
position: absolute;
top: 0;
right: 0;
bottom: 0;
left: 0;
z-index: $bolt-card-replacement-z-index-background;
overflow: hidden;
pointer-events: none;
user-select: none;
border-radius: $bolt-card-replacement-border-radius;
[rounded] & {
@include bolt-border-radius(large);
}
& + bolt-card-replacement-body {
margin-bottom: auto;
}
}
.c-bolt-card_replacement__background {
position: relative;
width: 100%;
height: 100%;
}
z-index needs to be set on the element that's controlling the stacking order, the children will follow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mikemai2awesome unfortunately this update alone isn't enough to fix the main issue I was running into:
That said, I'm testing out one additional CSS update to have the immediate children of <bolt-card-replacement>
automatically get position: relative
which fixes the issue... just testing if there's any gotchas.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mikemai2awesome check out the latest I just pushed up!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sghoweri Nice job putting this together so quickly. I added some inline comments/questions. Let me know what you think.
Also, the background image isn't visible for me locally or on feature branch: https://feature-update-mission-modal.boltdesignsystem.com/pattern-lab/?p=blueprints-t1-mission-landing--test-with-modal
...ern-lab/_patterns/03-blueprints/03-organisms/modals/_test-completed-modal--after-submit.twig
Show resolved
Hide resolved
...ern-lab/_patterns/03-blueprints/03-organisms/modals/_test-completed-modal--after-submit.twig
Show resolved
Hide resolved
...ern-lab/_patterns/03-blueprints/03-organisms/modals/_test-completed-modal--after-submit.twig
Show resolved
Hide resolved
...s/pattern-lab/_patterns/03-blueprints/03-organisms/modals/_test-completed-modal--rating.twig
Show resolved
Hide resolved
@danielamorse I should have a fix for that pushed up very shortly -- the image is there... it's just not showing up due to the related updates I pushed up to address @mikemai2awesome's feedback. |
packages/components/bolt-card-replacement/src/card-replacement/card-replacement.scss
Outdated
Show resolved
Hide resolved
...s/pattern-lab/_patterns/03-blueprints/03-organisms/modals/_test-completed-modal--rating.twig
Outdated
Show resolved
Hide resolved
|
||
|
||
// WIP Rating Component |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking ahead, how do you see this SASS being added to Academy? So far there's only vanilla CSS. Do you know if SASS is supported at the theme level? If not, we'll find out together :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@danielamorse this Sass is already getting pulled into Academy (by them installing and using Blueprints) -- if anything, looking ahead I see this Sass getting moved out of here and into a Rating-specific Component package.
I took care of my own comments above with the latest commit, plus the following:
|
PR was released with v2.21.0 |
Jira
http://vjira2:8080/browse/BDS-2089
Summary
Updates the existing Mission Modal blueprint with updated design comps; new Rating component.
Details
How to test