Re-enable branch and commit-specific now.sh deploy preview URLs on Github #1815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…liases work correctly
sghoweri
changed the title
danielamorse
approved these changes
Apr 8, 2020
danielamorse
deleted the
feature/re-enable-deploy-urls--including-branch-urls
branch
|
PR was released with v2.21.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira
http://vjira2:8080/browse/BDS-2037 (Related But Doesn't 100% Resolve)
Summary
Re-enables the our ability to easily find the commit-specific and branch-specific deployment URLs in Github -- a core piece of functionality that we unfortunately lost recently (when we added a temp workaround to the check run bad credentials error on Travis).
Details
This PR adds inline "View Deployment" buttons next to specific commits that are pushed up in addition to providing a super helpful box at the bottom of the PR screen with the latest branch and commit-specific URLs:
NOTE: I renamed the labels for these
branch-previewandcommit-previewdeployments mid-way through the work on this, hence why this PR has 4 links but this bugfix test PR only has the two expected links.How to test
Does it work? No Travis CI errors? Then ship it! 🚀
There's zero code in this PR that gets published to NPM so there's very little risk merging this in ASAP so everyone can start to take advantage of this.