DS-329 Remove Button from Micro Journey Editor #2294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type: feature
danielamorse
reviewed
Aug 9, 2021
There was a problem hiding this comment.
AFAICT there is no actual usage of bolt-button in micro journeys content, so this should be ok. Having Ross verify that is also reassuring.
@remydenton does WWO use this same editor? If so, should @cjwhitedev look at WWO before we make this change?
remydenton
approved these changes
Aug 11, 2021
There was a problem hiding this comment.
This looks great, thanks for the updates @cjwhitedev. I'm glad we realized we could just remove rather than sinking more time into making it work.
@danielamorse , WWO actually doesn't use the editor. WWO instances are created with fixed markup written by a developer, not a content author. It means a little less flexibility, but also way less complexity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira
https://pegadigitalit.atlassian.net/browse/DS-329
Summary
Removed Bolt-Button option from Micro Journey Editor
Details
Bolt-Button has been deprecated and slated for removal. Micro Journeys is also to be removed eventually. So rather than resolve any issues one might cause the other, we thought it best just to remove the button from the editor.
How to test
Review my code
Release notes
Removed Bolt-Button option from Micro Journey Editor