Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DS-590 page header + notifications design #2300

Merged
merged 65 commits into from
Jan 19, 2022

Conversation

mikemai2awesome
Copy link
Collaborator

@mikemai2awesome mikemai2awesome commented Aug 19, 2021

Jira

https://pegadigitalit.atlassian.net/browse/DS-590

Summary

Adds user notifications to Page Header component.

Details

  1. Related-sites nav and user nav are breaking changes. New data needs to be passed to create the new design.
  2. Page Header's nav-li template has new props: counter, signifier_only, signifier_before.
  3. Minor letter spacing tweak to xsmall headlines.
  4. Updated Page Header docs.

How to test

Run the branch locally and check all the demos under Page Header.

@github-actions github-actions bot added the type: feature List this PR in the 'Features' section of the release notes. label Aug 19, 2021
@colbytcook colbytcook temporarily deployed to feature/ds-590-page-header-notifications--branch-preview August 19, 2021 22:26 Inactive
@colbytcook colbytcook temporarily deployed to feature/ds-590-page-header-notifications--branch-preview August 20, 2021 21:23 Inactive
@colbytcook colbytcook temporarily deployed to feature/ds-590-page-header-notifications--branch-preview September 15, 2021 18:41 Inactive
@colbytcook colbytcook temporarily deployed to feature/ds-590-page-header-notifications--branch-preview September 15, 2021 22:29 Inactive
@colbytcook colbytcook requested a deployment to feature/ds-590-page-header-notifications--branch-preview September 15, 2021 22:33 Abandoned
@colbytcook colbytcook temporarily deployed to feature/ds-590-page-header-notifications--branch-preview September 16, 2021 22:24 Inactive
@colbytcook colbytcook requested a deployment to feature/ds-590-page-header-notifications--c8c532eb--commit-preview September 17, 2021 15:18 In progress
@colbytcook colbytcook temporarily deployed to feature/ds-590-page-header-notifications--branch-preview September 17, 2021 16:29 Inactive
@colbytcook colbytcook requested a deployment to feature/ds-590-page-header-notifications--branch-preview September 17, 2021 16:37 Abandoned
@colbytcook colbytcook requested a deployment to feature/ds-590-page-header-notifications--bcdc283e--commit-preview September 21, 2021 21:53 Abandoned
@colbytcook colbytcook had a problem deploying to feature/ds-590-page-header-notifications--branch-preview September 22, 2021 22:17 Failure
@colbytcook colbytcook temporarily deployed to feature/ds-590-page-header-notifications--branch-preview December 27, 2021 17:08 Inactive
@colbytcook colbytcook temporarily deployed to feature/ds-590-page-header-notifications--branch-preview December 27, 2021 17:39 Inactive
@colbytcook colbytcook temporarily deployed to feature/ds-590-page-header-notifications--branch-preview January 5, 2022 17:06 Inactive
@colbytcook colbytcook changed the title [DO NOT MERGE] DS-590 page header + notifications design DS-590 page header + notifications design Jan 5, 2022
@colbytcook colbytcook temporarily deployed to feature/ds-590-page-header-notifications--branch-preview January 5, 2022 21:06 Inactive
@colbytcook colbytcook temporarily deployed to feature/ds-590-page-header-notifications--branch-preview January 5, 2022 21:38 Inactive
Copy link
Collaborator

@danielamorse danielamorse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mikemai2awesome in the logged-in demo the Notifications menu is inside a <div> directly inside a <ul>. We're missing the <li>.

When I add the missing wrapper template (@bolt-components-page-header/page-header-nav-li.twig), I see extra padding around the Notifications content that wasn't there before.

Can you take a look at this? Let me know if you want me to push my docs-site edits.

@mikemai2awesome
Copy link
Collaborator Author

@danielamorse I just fixed it.

@remydenton
Copy link
Collaborator

I don't quite understand how the old content maps to the new. Specifically, how does this

Screen Shot 2022-01-18 at 5 11 05 PM

Become this?

Screen Shot 2022-01-18 at 5 11 13 PM

Copy link
Collaborator

@remydenton remydenton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! As discussed in standup, the answer to my previous question is that the content changes significantly. The plan is to hard-code those links so that they can be easily synchronized across sites.

@remydenton remydenton merged commit e559156 into master Jan 19, 2022
@remydenton remydenton deleted the feature/ds-590-page-header-notifications branch January 19, 2022 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature List this PR in the 'Features' section of the release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants