-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DS-590 page header + notifications design #2300
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mikemai2awesome in the logged-in demo the Notifications menu is inside a <div>
directly inside a <ul>
. We're missing the <li>
.
When I add the missing wrapper template (@bolt-components-page-header/page-header-nav-li.twig
), I see extra padding around the Notifications content that wasn't there before.
Can you take a look at this? Let me know if you want me to push my docs-site edits.
@danielamorse I just fixed it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved! As discussed in standup, the answer to my previous question is that the content changes significantly. The plan is to hard-code those links so that they can be easily synchronized across sites.
Jira
https://pegadigitalit.atlassian.net/browse/DS-590
Summary
Adds user notifications to Page Header component.
Details
counter
,signifier_only
,signifier_before
.How to test
Run the branch locally and check all the demos under Page Header.