WWW-960: mobile nav top link color #2314
Conversation
This rule is already overridden for desktop links in this line: https://github.com/boltdesignsystem/bolt/blob/37832407b915bc1f4be32851d1d1441799d1866e/packages/components/bolt-page-header/src/_page-header-desktop.scss#L315 Mobile links are the only ones it affects, and the only ones that are reported as having a problem in WWW-960.
This is only necessary because the changes in the following commit have greater specificity than the defaults for hover and focus states defined in the `bolt-page-header-action-trigger` mixin. 3167fb8
github-actions
bot
added
the
type: feature
colbytcook
temporarily deployed
to
feature/WWW-960-mobile-nav-top-link-color--branch-preview
|
All set. |
|
With the latest changes, top level links have a different color in focus state (black)... ... than other links in focus state (dark navy) I actually don't see a good reason to have an At the end of the day, I don't really care as long as stakeholders are happy, and you're the original author @mikemai2awesome, so your call. |
|
@remydenton They are not both in expanded state (one is acting as a heading and expanded, the other is an item and not expanded), so the color should be kept consistent (expanded state is black). |
I'm aware they're not both expanded. If you're trying to show that they're different (in terms of expanded/not expanded), why do they look the same when not in focus state? IMO, they should look identical, unless you want to distinguish between expanded and not-expanded links, in which case they should be styled differently both when focused and not. Pretty sure the original PR makes more sense, unless there are other situations I'm not aware of. |
|
@remydenton They shouldn't look the same intially. I intended headlines to take on headline color, links to take on link color, but I'm forced to change them to black which makes no sense. |
Fair, I think that's probably the root cause of why it feels weird to me. I'm fine with this as-is, but let me have stakeholders take a look at the Pattern Lab demo link first so that we don't run the risk of yet more change requests 😄 . |
|
@mikemai2awesome @remydenton it looks like Ross responded to the JIRA question, we should be good to merge this one! |
mikemai2awesome
deleted the
feature/WWW-960-mobile-nav-top-link-color
branch
Jira
https://pegadigitalit.atlassian.net/browse/WWW-960
Summary
Makes unselected top-level mobile links black for consistency
Details
See screenshots in the "visual changes" section below. All other colors should be unchanged.
How to test
See screenshots in the "visual changes" section below. All other colors should be unchanged.
Release notes
Visual changes
In the global nav, top-level links are now black instead of dark navy when not selected. For example, on https://boltdesignsystem.com/pattern-lab/?p=components-page-header-example-main-site-with-subnav
Before:
After:
