DS-582 Add information about twig file name on schema section #2316
Conversation
github-actions
bot
added
the
type: feature
There was a problem hiding this comment.
@adamszalapski code looks good 👍
Do you know why these changes aren't reflected on Accordion? I recall the logic of the schema template is kind of convoluted. Accordion might match some condition that these other components do not.
Page Header looks good. Navbar is showing incorrect Twig template names. Before we merge this, we should review each component with multiple schemas and fix the names in the schema where necessary. Let's discuss today in huddle.
|
@danielamorse @adamszalapski the reason the Accordion and the Grid are not showing the twig names is because they are using the old version of including the nested schemas. The new version you list an array of schemas in the package.json, the older model you include those files directly in the schema file. I am not sure if we should proceed to just update those two components to the new standard way or try to make this PR work with them. I think we should update those two components to the latest method. |
There was a problem hiding this comment.
Checked again with @colbytcook's update. Verified all the components/layouts with multiple schemas match the filenames in the docs.
danielamorse
changed the title
colbytcook
had a problem deploying
to
feature/DS-582--branch-preview
Jira
https://pegadigitalit.atlassian.net/browse/DS-582
Summary
Add information about the twig file name on the schema section.
Details
Applies to components with multiple schemas:
How to test
Run this code locally and check if the twig file name is shown on components with multiple schemas and it's not visible on single schemas.