Build Hero Demos with Layout #2331
Conversation
github-actions
bot
added
the
type: feature
colbytcook
requested a deployment
to
feature/DS-629-remove-code-snippet-WC-usage-in-PL--b624b92--commit-preview
There was a problem hiding this comment.
@cjwhitedev Let's convert all usage to twig. As we discussed before, we haven't landed on the naming conventions yet, that's why the Layout docs currently have a warning message. Using twig template will ensure it will continue to work even when we change up the HTML and naming conventions.
colbytcook
had a problem deploying
to
feature/DS-622-build-hero-with-layout--branch-preview
# Conflicts: # docs-site/src/pages/pattern-lab/_patterns/40-components/hero-deprecated/-25-hero--reverse-order--no-image.twig
colbytcook
temporarily deployed
to
feature/DS-622-build-hero-with-layout--branch-preview
| @@ -0,0 +1,40 @@ | |||
| {% set _content %} | |||
There was a problem hiding this comment.
Where did these examples come from (centered content, video and list, templates, centered form)? They are not in the Hero docs. If we are adding more pages, some real examples from prod would be helpful. Otherwise don't add more than what were shown before.
There was a problem hiding this comment.
They were requested. The details are in the ticket.
There was a problem hiding this comment.
@cjwhitedev I see. Can you build out exactly what they have in the screenshots? https://pegadigitalit.atlassian.net/browse/WWW-857
There was a problem hiding this comment.
@mikemai2awesome I added the live examples to the "Heroes with layout" folder on the doc site. I also moved the existing work to the test folder. Each live site example has a "Notes" section that give integration specifications on how to build each one of the heroes.
…the existing examples into the Test folder
colbytcook
had a problem deploying
to
feature/DS-622-build-hero-with-layout--branch-preview
colbytcook
temporarily deployed
to
feature/DS-622-build-hero-with-layout--branch-preview
colbytcook
requested a deployment
to
feature/DS-622-build-hero-with-layout--branch-preview
colbytcook
had a problem deploying
to
feature/DS-622-build-hero-with-layout--branch-preview
colbytcook
temporarily deployed
to
feature/DS-622-build-hero-with-layout--branch-preview
colbytcook
temporarily deployed
to
feature/DS-622-build-hero-with-layout--branch-preview
Jira
DS-622
Summary
Show Hero examples using Layout
Details
We want to deprecate and remove the Hero Component, and not have a stand-alone replacement for it. These are demos showing how to use layout in different ways to replace Hero.
How to test
Pull the branch and compare the new layout hero demos against the Hero Component demos.
Release notes
Deprecated Hero Component and supplied replacement demos using layout.