-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DS-629 Remove Code Snippet WC usage in PL #2333
DS-629 Remove Code Snippet WC usage in PL #2333
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Please resolve conflicts with master. @MarcinMr
…9-remove-code-snippet-WC-usage-in-PL # Conflicts: # docs-site/src/pages/docs/00-getting-started/00-index.md # docs-site/src/pages/pattern-lab/_patterns/20-elements/icon/20-icon-use-case-custom-svg.twig # docs-site/src/pages/pattern-lab/_patterns/40-components/icon-deprecated/-20-icon-adding-custom-icons.twig # docs-site/src/pages/pattern-lab/_patterns/40-components/modal/35-modal-usage-javascript.twig
…e-code-snippet-WC-usage-in-PL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MarcinMr nicely done! I checked the first quarter of these thoroughly and everything looked perfect. Did a quick review of the rest. Building and rendering as expected.
Thanks for adding Release Notes here. However, it is not necessary for this PR because the updates are only to Pattern Lab (Bolt internal), and Release Notes are for consumers of Bolt. The only note we need is in #2317.
Thanks @danielamorse for review and for the PR "release notes" tip :) |
Jira
https://pegadigitalit.atlassian.net/browse/DS-629
Summary
The Old
<bolt-code-snippet>
component was replaced with a<code>
markup for inline snippets, attributes were disregarded in these examples. Other block snippets instances were replaced with the new Code Snippet Twig component.Details
The codebase was searched for
<bolt-code-snippet
. All these instances were replaced with the new code snippet.How to test
Pull the branch. Check if there are no more instances of the old code component snippet -
<bolt-code-snippet
. Make sure the new code snippets render properly.