Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DS-629 Remove Code Snippet WC usage in PL #2333

Conversation

MarcinMr
Copy link
Collaborator

@MarcinMr MarcinMr commented Sep 29, 2021

Jira

https://pegadigitalit.atlassian.net/browse/DS-629

Summary

The Old <bolt-code-snippet> component was replaced with a <code> markup for inline snippets, attributes were disregarded in these examples. Other block snippets instances were replaced with the new Code Snippet Twig component.

Details

The codebase was searched for <bolt-code-snippet. All these instances were replaced with the new code snippet.

How to test

Pull the branch. Check if there are no more instances of the old code component snippet - <bolt-code-snippet. Make sure the new code snippets render properly.

Mroczko added 30 commits September 27, 2021 13:25
Copy link
Collaborator

@mikemai2awesome mikemai2awesome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please resolve conflicts with master. @MarcinMr

@danielamorse danielamorse changed the base branch from master to feature/code-snippet-rebuild September 29, 2021 20:24
…9-remove-code-snippet-WC-usage-in-PL

# Conflicts:
#	docs-site/src/pages/docs/00-getting-started/00-index.md
#	docs-site/src/pages/pattern-lab/_patterns/20-elements/icon/20-icon-use-case-custom-svg.twig
#	docs-site/src/pages/pattern-lab/_patterns/40-components/icon-deprecated/-20-icon-adding-custom-icons.twig
#	docs-site/src/pages/pattern-lab/_patterns/40-components/modal/35-modal-usage-javascript.twig
@colbytcook colbytcook had a problem deploying to feature/DS-629-remove-code-snippet-WC-usage-in-PL--branch-preview September 29, 2021 21:56 Failure
Copy link
Collaborator

@danielamorse danielamorse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MarcinMr nicely done! I checked the first quarter of these thoroughly and everything looked perfect. Did a quick review of the rest. Building and rendering as expected.

Thanks for adding Release Notes here. However, it is not necessary for this PR because the updates are only to Pattern Lab (Bolt internal), and Release Notes are for consumers of Bolt. The only note we need is in #2317.

@danielamorse danielamorse merged commit 4a81f5a into feature/code-snippet-rebuild Sep 30, 2021
@danielamorse danielamorse deleted the feature/DS-629-remove-code-snippet-WC-usage-in-PL branch September 30, 2021 14:15
@MarcinMr
Copy link
Collaborator Author

@MarcinMr nicely done! I checked the first quarter of these thoroughly and everything looked perfect. Did a quick review of the rest. Building and rendering as expected.

Thanks for adding Release Notes here. However, it is not necessary for this PR because the updates are only to Pattern Lab (Bolt internal), and Release Notes are for consumers of Bolt. The only note we need is in #2317.

Thanks @danielamorse for review and for the PR "release notes" tip :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants