Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DS 653 Update icon element HTML demos #2345

Merged
merged 24 commits into from
Oct 18, 2021
Merged

DS 653 Update icon element HTML demos #2345

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
782c92d
DS-653: Update demo - basic icon
Oct 13, 2021
ccb2a98
DS-653: Update demo - icon size
Oct 13, 2021
4e5e405
DS-653: Update demo - icon colr
Oct 13, 2021
bedb7a2
DS-653: Update demo - icon use case
Oct 13, 2021
c1d20e2
DS-653: Update demo - icon use case
Oct 13, 2021
0cdd3fe
DS-653: Update demo - icon use case docs
Oct 13, 2021
2632fcc
DS-653: Change request - add aria-hidden on icon doc
Oct 15, 2021
4d1edc9
DS-653: Change request - add aria-hidden on icon-size docs
Oct 15, 2021
7a57021
DS-653: Change request - add aria-hidden on icon-theme docs
Oct 15, 2021
4ffc2ed
DS-653: Change request - add aria-hidden on icon-color docs
Oct 15, 2021
2fa8a4c
DS-653: Change request - add aria-hidden on icon-custom-colors docs
Oct 15, 2021
ad91dd3
DS-653: Change request - add aria-hidden on icon-name docs
Oct 15, 2021
3558650
DS-653: Change request - add aria-hidden on image-size docs
Oct 15, 2021
4076440
DS-653: Change request - add aria-hidden on image-source docs
Oct 15, 2021
c5369e3
DS-653: Change request - add aria-hidden on image-lazy docs
Oct 15, 2021
f2a164a
DS-653: Change request - add aria-hidden on a docsite-src-tempaltes-h…
Oct 15, 2021
9272511
DS-653: Change request - add attributes to svg on icon-use-case element
Oct 15, 2021
b62f0ed
DS-653: add missing enable-background attr to bolt icons twigs
Oct 15, 2021
65c875d
DS-653: add missing enable-background attr to bolt icons svgs
Oct 15, 2021
00cb304
DS-653: icon test update
Oct 15, 2021
6efdb2e
ds-653: fix doc
mikemai2awesome Oct 15, 2021
754759c
ds-653: fix typos
mikemai2awesome Oct 15, 2021
59e1b71
ds-653: rewrite a sentence
mikemai2awesome Oct 15, 2021
608c164
ds-653: add fill attribute
mikemai2awesome Oct 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs-site/src/pages/pattern-lab/_patterns/20-elements/icon/05-icon.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@

{% set html_markup %}
{% verbatim %}
<svg class="e-bolt-icon" aria-hidden="true">...</svg>
<svg enable-background="new 0 0 32 32" viewBox="0 0 32 32" xmlns="http://www.w3.org/2000/svg" class="e-bolt-icon" aria-hidden="true">...</svg>
{% endverbatim %}
{% endset %}

Expand Down
2 changes: 1 addition & 1 deletion docs-site/src/pages/pattern-lab/_patterns/20-elements/icon/10-icon-size.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@

{% set html_markup %}
{% verbatim %}
<svg class="e-bolt-icon e-bolt-icon--xlarge" aria-hidden="true">...</svg>
<svg enable-background="new 0 0 32 32" viewBox="0 0 32 32" xmlns="http://www.w3.org/2000/svg" class="e-bolt-icon e-bolt-icon--xlarge" aria-hidden="true">...</svg>
{% endverbatim %}
{% endset %}

Expand Down
2 changes: 1 addition & 1 deletion docs-site/src/pages/pattern-lab/_patterns/20-elements/icon/15-icon-color.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@

{% set html_markup %}
{% verbatim %}
<svg class="e-bolt-icon e-bolt-icon--navy" aria-hidden="true">...</svg>
<svg enable-background="new 0 0 32 32" viewBox="0 0 32 32" xmlns="http://www.w3.org/2000/svg" class="e-bolt-icon e-bolt-icon--navy" aria-hidden="true">...</svg>
{% endverbatim %}
{% endset %}

Expand Down
4 changes: 2 additions & 2 deletions docs-site/src/pages/pattern-lab/_patterns/20-elements/icon/20-icon-use-case-custom-svg.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
</bolt-li>
<bolt-li>If you choose a HTML usage:
<bolt-ul>
<bolt-li>Add the element class <code>class="e-bolt-icon"</code> and relevant modifier classes, and add the attribute <code>aria-hidden="true"</code> to the <code>&lt;svg&gt;</code> HTML element. Then you can display the icon using the modified <code>&lt;svg&gt;</code> markup.</bolt-li>
<bolt-li>Add the element class <code>class="e-bolt-icon"</code> and relevant modifier classes, add the attribute <code>aria-hidden="true"</code> and the three key attributes (if they weren't provided by default): <code>enable-background="new 0 0 32 32" viewBox="0 0 32 32" xmlns="http://www.w3.org/2000/svg" </code> to the <code>&lt;svg&gt;</code> HTML element. Then you can display the icon using the modified <code>&lt;svg&gt;</code> markup.</bolt-li>
</bolt-ul>
</bolt-li>
</bolt-ol>
Expand All @@ -44,7 +44,7 @@

{% set html_markup %}
{% verbatim %}
<svg class="e-bolt-icon e-bolt-icon--xlarge e-bolt-icon--orange" aria-hidden="true" viewBox="0 0 496 512">
<svg enable-background="new 0 0 32 32" viewBox="0 0 32 32" xmlns="http://www.w3.org/2000/svg" class="e-bolt-icon e-bolt-icon--xlarge e-bolt-icon--orange" aria-hidden="true">
<path d="M248 8C111 8 0 119 0 256s111 248 248 248 248-111 248-248S385 8 248 8zM136 240c0-9.3 4.1-17.5 10.5-23.4l-31-9.3c-8.5-2.5-13.3-11.5-10.7-19.9 2.5-8.5 11.4-13.2 19.9-10.7l80 24c8.5 2.5 13.3 11.5 10.7 19.9-2.1 6.9-8.4 11.4-15.3 11.4-.5 0-1.1-.2-1.7-.2.7 2.7 1.7 5.3 1.7 8.2 0 17.7-14.3 32-32 32S136 257.7 136 240zm168 154.2c-27.8-33.4-84.2-33.4-112.1 0-13.5 16.3-38.2-4.2-24.6-20.5 20-24 49.4-37.8 80.6-37.8s60.6 13.8 80.6 37.8c13.8 16.5-11.1 36.6-24.5 20.5zm76.6-186.9l-31 9.3c6.3 5.8 10.5 14.1 10.5 23.4 0 17.7-14.3 32-32 32s-32-14.3-32-32c0-2.9.9-5.6 1.7-8.2-.6.1-1.1.2-1.7.2-6.9 0-13.2-4.5-15.3-11.4-2.5-8.5 2.3-17.4 10.7-19.9l80-24c8.4-2.5 17.4 2.3 19.9 10.7 2.5 8.5-2.3 17.4-10.8 19.9z" />
</svg>
{% endverbatim %}
Expand Down