Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: refine neutral gray colors #2350

Merged
merged 1 commit into from Oct 14, 2021
Merged

Fix: refine neutral gray colors #2350

merged 1 commit into from Oct 14, 2021

Conversation

mikemai2awesome
Copy link
Collaborator

Summary

Minor adjustments to mode specific neutral gray color to meet minimum color contrast.

Details

  1. Mode vars updated
  2. Button css updated to ensure there's no visual regressions

How to test

Run the branch locally and check the button docs, make sure there's no visual regressions (shadow color is exactly the same as on master).

@github-actions github-actions bot added the type: feature List this PR in the 'Features' section of the release notes. label Oct 13, 2021
colbytcook
colbytcook approved these changes Oct 14, 2021
View reviewed changes
Copy link
Contributor

@colbytcook colbytcook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compared my local and boltdesignsystem.com and confirm there is not shadow difference between the Bolt Button Element and the Bolt Button Component.

@danielamorse danielamorse merged commit 70ebb39 into master Oct 14, 2021
@danielamorse danielamorse deleted the feature/update-neutral-grays branch October 14, 2021 17:38
@mikemai2awesome mikemai2awesome restored the feature/update-neutral-grays branch October 14, 2021 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielamorse danielamorse danielamorse approved these changes

@colbytcook colbytcook colbytcook approved these changes

Assignees
No one assigned
Labels
type: feature List this PR in the 'Features' section of the release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mikemai2awesome @danielamorse @colbytcook