New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DS-662 Pega.com security feedback #2357
Merged
mikemai2awesome
merged 89 commits into
master
from
feature/DS-662-pega-com-security-feedback
Oct 28, 2021
Merged
DS-662 Pega.com security feedback #2357
mikemai2awesome
merged 89 commits into
master
from
feature/DS-662-pega-com-security-feedback
Oct 28, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colbytcook
approved these changes
Oct 19, 2021
colbytcook
temporarily deployed
to
feature/DS-662-pega-com-security-feedback--branch-preview
October 19, 2021 13:54
Inactive
colbytcook
temporarily deployed
to
feature/DS-662-pega-com-security-feedback--branch-preview
October 19, 2021 15:03
Inactive
@MarcinMr That's correct. Don't remove something that a component is supposed to do. |
mikemai2awesome
requested changes
Oct 25, 2021
.../pattern-lab/_patterns/40-components/listing-teaser/20-listing-teaser-status-and-action.twig
Outdated
Show resolved
Hide resolved
...es/pattern-lab/_patterns/50-pages/15-d8-resource-details-pages/00-resource-details-page.twig
Outdated
Show resolved
Hide resolved
...terns/50-pages/60-academy/05-pages/t1-landing-pages/mission-landing/acd-mission-landing.twig
Outdated
Show resolved
Hide resolved
colbytcook
had a problem deploying
to
feature/DS-662-pega-com-security-feedback--branch-preview
October 27, 2021 10:13
Failure
colbytcook
had a problem deploying
to
feature/DS-662-pega-com-security-feedback--branch-preview
October 27, 2021 11:30
Failure
colbytcook
had a problem deploying
to
feature/DS-662-pega-com-security-feedback--branch-preview
October 27, 2021 12:43
Failure
colbytcook
had a problem deploying
to
feature/DS-662-pega-com-security-feedback--branch-preview
October 27, 2021 13:13
Failure
mikemai2awesome
requested changes
Oct 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MarcinMr Missed a few, let's update those and resolve the failing tests.
.../src/pages/pattern-lab/_patterns/40-components/card/card-replacement-with-web-component.twig
Outdated
Show resolved
Hide resolved
docs-site/src/pages/pattern-lab/_patterns/50-pages/70-community/-community-search-layout.twig
Outdated
Show resolved
Hide resolved
docs-site/src/pages/pattern-lab/_patterns/50-pages/70-community/-community-search-layout.twig
Outdated
Show resolved
Hide resolved
docs-site/src/pages/pattern-lab/_patterns/50-pages/70-community/-community-search-layout.twig
Outdated
Show resolved
Hide resolved
colbytcook
had a problem deploying
to
feature/DS-662-pega-com-security-feedback--branch-preview
October 27, 2021 14:57
Failure
…o feature/DS-662-pega-com-security-feedback the commit
mikemai2awesome
approved these changes
Oct 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira
https://pegadigitalit.atlassian.net/browse/DS-662
Summary
References to Pega sites were deleted or switched to another link (for example google.com).
Details
Repository was searched for:
References were removed or replaced with a neutral URL
How to test
Pull the branch. Check if all references to the above URLs don't exist anymore in the repo.